Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump webassemblyjs #8064

Merged
merged 1 commit into from Sep 21, 2018
Merged

bump webassemblyjs #8064

merged 1 commit into from Sep 21, 2018

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Sep 21, 2018

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

Fixes some licensing issues, xtuc/webassemblyjs#452.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@sokra
Copy link
Member

sokra commented Sep 21, 2018

@davidstaheli

image

-1m?

@xtuc
Copy link
Member Author

xtuc commented Sep 21, 2018

In checks it reported
screenshot from 2018-09-21 11-29-17

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 61718d4 into webpack:master Sep 21, 2018
@sokra
Copy link
Member

sokra commented Sep 21, 2018

Thanks

@xtuc xtuc deleted the chore-bump-webassemblyjs13 branch September 21, 2018 10:02
@davidstaheli
Copy link
Contributor

@sokra, regarding "-1m"... Wow... your mail arrives before it's sent. Thanks for letting me know so we can fix it.

@davidstaheli
Copy link
Contributor

Hi @sokra. It turns out that the build completing in -1m is actually from GitHub and not data we're sending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants