Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ConstPlugin] fix bug introduced by evaluation of && and || #8270

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

ljqx
Copy link
Member

@ljqx ljqx commented Oct 25, 2018

This PR closes #8269. When code is like

return'development'===process.env.NODE_ENV&&'foo'

It's valid but now it would be translated to

returnfalse&&'foo'

This fix changes it to

return false&&'foo'

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
no as it's bugfix

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 5e5e7b7 into webpack:master Oct 25, 2018
@sokra
Copy link
Member

sokra commented Oct 25, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

void returnfalse
3 participants