Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

while grouping nodes include at least one node on each side #8416

Merged
merged 1 commit into from
Nov 25, 2018
Merged

while grouping nodes include at least one node on each side #8416

merged 1 commit into from
Nov 25, 2018

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 24, 2018

fixes #8407

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit a1d4802 into master Nov 25, 2018
@sokra sokra deleted the bugfix/split-chunks-zero-min branch November 25, 2018 10:34
@chrisckc chrisckc mentioned this pull request Nov 25, 2018
Closed
@chrisckc
Copy link

chrisckc commented Nov 25, 2018 •
edited

@sokra tested the merged 'bugfix/split-chunks-zero-min' and found it only provides a partial fix for the build hang issue, see my comment here:
#8407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: CI-ok PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimization.splitChunks.maxSize throws error or causes build to hang
3 participants
@sokra @webpack-bot @chrisckc