Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug which causes incorrect providedExports for cached modules #8457

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

sokra
Copy link
Member

@sokra sokra commented Dec 3, 2018

Always update providedExports when they have dependencies

fixes #8455

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

Always update providedExports when they have dependencies

fixes #8455
@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 96f625c into master Dec 4, 2018
@sokra sokra deleted the bugfix/rebuild-provided-exports branch December 4, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing module dependency between shared and async bundles causing code updates to disappear
2 participants