fix side-effects example, rebuild examples #8676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
hulkish
force-pushed
the
fix-side-effects-example
branch
2 times, most recently
from
8030bbc
to
d3a73b7
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
force-pushed
the
fix-side-effects-example
branch
from
d3a73b7
to
2209b8a
Compare
sokra
approved these changes
Jan 25, 2019
|
@sokra I was thinking, shouldn't this already be covered with |
Yes, mode production also enables it, but the examples run in mode none to be readable. Production would include other optimizations like minimizing and scope-hoisting which would make it less obvious what's happening... |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed current
examples/side-effects/README.mdthat what is claimed is not what is shown in output. This pr aims to correct this.What kind of change does this PR introduce?
fix example
Did you add tests for your changes?
N/A
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
N/A