Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump webassemblyjs #8834

Merged
merged 1 commit into from Feb 28, 2019
Merged

Bump webassemblyjs #8834

merged 1 commit into from Feb 28, 2019

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Feb 26, 2019

Refs wasm-tool/wasm-pack-plugin#53,
rustwasm/wasm-bindgen#1267

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

sendilkumarn
sendilkumarn approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@sendilkumarn sendilkumarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@sokra sokra merged commit 1bb3938 into webpack:master Feb 28, 2019
@sokra
Copy link
Member

sokra commented Feb 28, 2019

Thanks

@xtuc xtuc deleted the chore-bump-webassemblyjs24 branch February 28, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sendilkumarn sendilkumarn sendilkumarn approved these changes

Assignees
No one assigned
Labels
PR: CI-ok PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xtuc @webpack-bot @sokra @sendilkumarn