Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link in warning #9029

Merged
merged 3 commits into from Apr 17, 2019
Merged

Update link in warning #9029

merged 3 commits into from Apr 17, 2019

Conversation

EugeneHlushko
Copy link
Member

We had moved the page from /concepts to /configuration

What kind of change does this PR introduce?
Update copy

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
no

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@EugeneHlushko EugeneHlushko changed the title Mode/warning misc(warning) Update link in warning Apr 10, 2019
@EugeneHlushko EugeneHlushko changed the title misc(warning) Update link in warning Update link in warning Apr 10, 2019
Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@EugeneHlushko
Copy link
Member Author

Whats wrong with CI ?

@alexander-akait
Copy link
Member

Difference hash:

   - "Hash: c07d925d7e60129ffc69
    + "Hash: 51d6721efa0198f0e5a4

@webpack-bot
Copy link
Contributor

@EugeneHlushko Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@hiroppy Please review the new changes.

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 42db81a into webpack:master Apr 17, 2019
@sokra
Copy link
Member

sokra commented Apr 17, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants