Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow top-level return in script parsing. Fixes issue 8509 in master,… #9046

Merged
merged 1 commit into from Apr 20, 2019

Conversation

mwijngaard
Copy link
Contributor

… like PR 8510 fixed it for 'next'

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Contributor

It looks like this Pull Request doesn't include enough test cases (based on Code Coverage analysis of the PR diff).

A PR need to be covered by tests if you add a new feature (we want to make sure that your feature is working) or if you fix a bug (we want to make sure that we don't run into a regression in future).

@mwijngaard Please check if this is appliable to your PR and if you can add more test cases.

Read the test readme for details how to write test cases.

@alexander-akait
Copy link
Member

alexander-akait commented Apr 18, 2019

Please accept CLA

@webpack-bot
Copy link
Contributor

Hi @mwijngaard.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own master branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.


// Test CJS top-level return
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add new test instead modify current?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing. The idea is for this to be exactly the same change as #8510 , which was already merged into 'next'. If you really prefer the test to be split it up I can to that, but it seems to me that that does not benefit understandability when comparing the branches.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sokra sokra merged commit 81cf088 into webpack:master Apr 20, 2019
@sokra
Copy link
Member

sokra commented Apr 20, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants