New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle cryptic error message being thrown #9306
Conversation
misconfigured config file
For maintainers only:
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test cases
test/Validation.test.js seems like a good place
@sokra I'm not that familiar with the code-base. Can you throw light on how it should be regarding writing the test case 🤔 |
Run Then you should be able to run the Validation tests with Copy one of the tests in the file and create a invalid config like in the issue. Running the test will update the snapshot to the expected error message. |
see 226e8ce |
So are we all set to go ahead? |
Yep, thanks |
misconfigured config file
Fixes #9295
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
N/A
Does this PR introduce a breaking change?
Nope
What needs to be documented once your changes are merged?
Nil