Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cryptic error message being thrown #9306

Merged
merged 3 commits into from Jun 19, 2019

Conversation

jamesgeorge007
Copy link
Member

misconfigured config file

Fixes #9295

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
N/A

Does this PR introduce a breaking change?
Nope

What needs to be documented once your changes are merged?
Nil

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test cases

test/Validation.test.js seems like a good place

@jamesgeorge007
Copy link
Member Author

@sokra I'm not that familiar with the code-base. Can you throw light on how it should be regarding writing the test case 🤔

@sokra
Copy link
Member

sokra commented Jun 19, 2019

Run yarn setup first.

Then you should be able to run the Validation tests with yarn jest Validation --watch -u. The -u updates the snapshots automatically.

Copy one of the tests in the file and create a invalid config like in the issue. Running the test will update the snapshot to the expected error message.

@sokra
Copy link
Member

sokra commented Jun 19, 2019

see 226e8ce

@jamesgeorge007
Copy link
Member Author

So are we all set to go ahead?

@sokra sokra merged commit 494e16b into webpack:master Jun 19, 2019
@sokra
Copy link
Member

sokra commented Jun 19, 2019

Yep, thanks

@jamesgeorge007 jamesgeorge007 deleted the hotfix/refactor branch June 23, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cryptic error message on misconfigured config file
3 participants