-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update acorn for dynamic import #9370
Conversation
|
For maintainers only:
|
I've signed the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, yep, it should solve this issue
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Thanks |
Thanks, it works for release 4.36.0 |
might resolve parts of #8656 ?
What kind of change does this PR introduce?
Acorn merged dynamic imports in version
6.2.0
, so the need foracorn-dynamic-import
is no longer needed.Did you add tests for your changes?
No, but I ran all the tests which include
import()
Does this PR introduce a breaking change?
No, I don't believe so
What needs to be documented once your changes are merged?
...nothing ? I'm no expert on acorn so feel free to close this issue if im way off