Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update acorn for dynamic import #9370

Merged
merged 1 commit into from
Jul 6, 2019
Merged

feat: update acorn for dynamic import #9370

merged 1 commit into from
Jul 6, 2019

Conversation

DRoet
Copy link
Contributor

@DRoet DRoet commented Jul 5, 2019

might resolve parts of #8656 ?

What kind of change does this PR introduce?
Acorn merged dynamic imports in version 6.2.0, so the need for acorn-dynamic-import is no longer needed.

Did you add tests for your changes?
No, but I ran all the tests which include import()

Does this PR introduce a breaking change?
No, I don't believe so

What needs to be documented once your changes are merged?
...nothing ? I'm no expert on acorn so feel free to close this issue if im way off

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@DRoet
Copy link
Contributor Author

DRoet commented Jul 5, 2019

I've signed the CLA

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, yep, it should solve this issue

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit f092150 into webpack:master Jul 6, 2019
@sokra
Copy link
Member

sokra commented Jul 6, 2019

Thanks

@PerspectivesLab
Copy link

Thanks, it works for release 4.36.0
95d21bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants