Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSONP main template to allow currently forbidden chunk IDs (#9491) #9493

Merged
merged 1 commit into from Aug 1, 2019
Merged

Fix JSONP main template to allow currently forbidden chunk IDs (#9491) #9493

merged 1 commit into from Aug 1, 2019

Conversation

Lyrkan
Copy link
Contributor

@Lyrkan Lyrkan commented Jul 30, 2019

What kind of change does this PR introduce?

This PR fixes #9491 by allowing to use entrypoint names like constructor with runtimeChunk: 'single'/namedChunks: true.

Doing that currently resulted in the following error at runtime (see the issue for more details):

runtime.js:26 Uncaught TypeError: resolves.shift(...) is not a function
    at Array.webpackJsonpCallback [as push] (runtime.js:26)
    at constructor.js:1

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

That shouldn't be the case

What needs to be documented once your changes are merged?

N/A

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit ba20513 into webpack:master Aug 1, 2019
@sokra
Copy link
Member

sokra commented Aug 1, 2019

Thanks

@Lyrkan Lyrkan deleted the 9491-fix-entrypoint-names branch August 1, 2019 12:05
@weaverryan weaverryan mentioned this pull request Aug 9, 2019
Merged
weaverryan added a commit to symfony/webpack-encore that referenced this pull request Aug 9, 2019
@weaverryan
minor #624 Fixing hashes in tests (weaverryan)
a89be04 
This PR was merged into the master branch.

Discussion
----------

Fixing hashes in tests

The runtime changes are probably due to the yarn.lock bump, which now includes
webpack/webpack#9493

The one main.js change is a mystery.

Commits
-------

be98233 Fixing hashes in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
PR: CI-ok PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"resolves.shift(...) is not a function" when using a forbidden entrypoint name
3 participants
@Lyrkan @webpack-bot @sokra