Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazy require webassemblyjs using modules #9857

Merged
merged 1 commit into from
Oct 18, 2019
Merged

lazy require webassemblyjs using modules #9857

merged 1 commit into from
Oct 18, 2019

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 18, 2019

fixes #9781

What kind of change does this PR introduce?
performance

Did you add tests for your changes?
existing tests

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack webpack deleted a comment from webpack-bot Oct 18, 2019
@webpack-bot
Copy link
Contributor

webpack-bot commented Oct 18, 2019 •
edited by sokra
Loading

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra sokra merged commit 2c41319 into master Oct 18, 2019
@sokra sokra deleted the perf/lazy-require-wasm branch October 18, 2019 12:36
@webpack-bot
Copy link
Contributor

I've created an issue to backport this.

@webpack-bot webpack-bot mentioned this pull request Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: CI-ok PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webpack memory usage on require
2 participants
@sokra @webpack-bot