Fix: PHP 7.2 E_WARNING about sizeof() #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support Laravel 5.5
Remove extra whitespace
|
Although there's already a pull request about this on #82, I think my solution is better. Further, as this previous solution hasn't been quoted on the issue I didn't see it. 😞 |
|
This PR reverted my fix from #72 . For some reason is it not showing in the "Files changed", but you can see the commit listed here. See a70f7ea39101c09a9ea0f3eddd2eefb80de9410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As PHP 7.2, an E_WARNING will be emitted when attempting to
count()non-countable types (this includes thesizeof()alias function). [source]Since
nullis a non-countable type, trying to use this bundle with bleeding PHP will throw a error when seeding database.This pull request closes issue #79.