Add support for thenable dynamic import w/ destructured arg (resolves #…

…688)

packages/knip/fixtures/imports/dir/import-f.ts

@@ -0,0 +1,3 @@
+export const dynamic = () => 1;
+
+export const named = { default: 1, identifier13: 13, identifier14: 14 };

packages/knip/fixtures/imports/index.ts

@@ -9,7 +9,9 @@ const fn = (_: any) => {};
 const topLevel = await import('./top-level-await-import');
 const { top } = await import('./top-level-await-import');
 
-const dynamic = () => import('./dir/import-b').then(m => m.dynamic);
+const dynamicB = () => import('./dir/import-b').then(m => m.dynamic);
+
+const dynamicF = () => import('./dir/import-f').then(({ dynamic, named: renamed }) => [dynamic, renamed]);
 
 import('./top-level-side-effects-call');
 

packages/knip/src/typescript/visitors/dynamic-imports/importCall.ts

@@ -44,6 +44,18 @@ export default visit(
                         return { identifier, specifier, pos };
                       });
                     }
+                  } else if (ts.isObjectBindingPattern(arg.name)) {
+                    // Pattern: import('specifier').then({ identifier } => identifier);
+                    return arg.name.elements.map(element => {
+                      const identifier = (element.propertyName ?? element.name).getText();
+                      const alias = element.propertyName ? element.name.getText() : undefined;
+                      return {
+                        identifier,
+                        alias,
+                        specifier,
+                        pos: element.pos,
+                      };
+                    });
                   }
                 }
                 return { identifier: 'default', specifier, pos };

packages/knip/test/imports.test.ts

@@ -15,7 +15,7 @@ test('Support various ways to import modules', async () => {
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    processed: 23,
-    total: 23,
+    processed: 24,
+    total: 24,
   });
 });