Support import.meta.resolve (resolves #642)

webpro-nl · Jun 12, 2024 · 177baa2 · 177baa2
1 parent 2ec5189
commit 177baa2
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/packages/knip/fixtures/imports/import-meta-resolve.js b/packages/knip/fixtures/imports/import-meta-resolve.js
diff --git a/packages/knip/fixtures/imports/index.ts b/packages/knip/fixtures/imports/index.ts
@@ -37,6 +37,10 @@ const templateStringInternal = () => {
   return import('./dir/mod');
 };
 
+const importMetaResolve = () => {
+  return import.meta.resolve('./import-meta-resolve.js');
+};
+
 function promiseAll() {
   return {
     async fn() {

diff --git a/packages/knip/fixtures/imports/tsconfig.json b/packages/knip/fixtures/imports/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "compilerOptions": {
     "types": ["node"],
-    "esModuleInterop": true
+    "esModuleInterop": true,
+    "module": "nodenext"
   }
 }
diff --git a/packages/knip/src/typescript/visitors/dynamic-imports/propertyAccessCall.ts b/packages/knip/src/typescript/visitors/dynamic-imports/propertyAccessCall.ts
@@ -5,7 +5,7 @@ import { importVisitor as visit } from '../index.js';
 export default visit(
   () => true,
   node => {
-    if (isPropertyAccessCall(node, 'require.resolve')) {
+    if (isPropertyAccessCall(node, 'require.resolve') || isPropertyAccessCall(node, 'import.meta.resolve')) {
       // Pattern: require.resolve('specifier')
       if (node.arguments[0] && ts.isStringLiteralLike(node.arguments[0])) {
         const specifier = node.arguments[0].text;

diff --git a/packages/knip/test/imports.test.ts b/packages/knip/test/imports.test.ts
@@ -15,7 +15,7 @@ test('Support various ways to import modules', async () => {
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    processed: 22,
-    total: 22,
+    processed: 23,
+    total: 23,
   });
 });