Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lockfile-lint config filename #683

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

jerone
Copy link
Contributor

@jerone jerone commented Jun 18, 2024

The dot before lockfile-lint.config.js is not a supported config.
Not in cosmiconfig v8 & v9.

The list of supported configs is actually larger:
https://github.com/lirantal/lockfile-lint/blob/main/packages/lockfile-lint/README.md#file-based-configuration
https://github.com/cosmiconfig/cosmiconfig?tab=readme-ov-file#cosmiconfig

But that is out of scope for this bugfix.

Copy link

netlify bot commented Jun 18, 2024

‼️ Deploy request for knip rejected.

Name Link
🔨 Latest commit 07793b7

@webpro
Copy link
Collaborator

webpro commented Jun 18, 2024

Thanks @jerone!

That extended list isn't documented so I think we're good for now, right?

@webpro webpro merged commit f5304b6 into webpro-nl:main Jun 18, 2024
11 checks passed
@webpro
Copy link
Collaborator

webpro commented Jun 18, 2024

🚀 This pull request is included in v5.21.1. See Release 5.21.1 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

@jerone
Copy link
Contributor Author

jerone commented Jun 18, 2024

That extended list isn't documented so I think we're good for now, right?

The list is documented here: https://github.com/lirantal/lockfile-lint/blob/main/packages/lockfile-lint/README.md#file-based-configuration
Lockfile-lint is actually using cosmiconfig v9 now, which supports the full list of config documented here: https://github.com/cosmiconfig/cosmiconfig#cosmiconfig

@jerone jerone deleted the bugfix/lockfile-lint-config branch June 18, 2024 10:08
@webpro
Copy link
Collaborator

webpro commented Jun 18, 2024

Yes I meant documented by lockfile-lint itself.

@jerone
Copy link
Contributor Author

jerone commented Jun 18, 2024

  1. A "lockfile-lint" key in your package.json file.
  2. A .lockfile-lintrc file, written in JSON or YAML, with optional extensions: .json/.yaml/.yml (without extension takes precedence).
  3. A .lockfile-lint.js or lockfile-lint.config.js file that exports an object.
  4. A .lockfile-lint.toml file, written in TOML (the .toml extension is required).
  1. .lockfile-lintrc
    .lockfile-lintrc.json
    .lockfile-lintrc.yaml
    .lockfile-lintrc.yml
  2. .lockfile-lint.js
    lockfile-lint.config.js
  3. .lockfile-lint.toml

@webpro
Copy link
Collaborator

webpro commented Jun 18, 2024

LOL, totally missed that, sorry, Feel free to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants