Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue async component imports are not detected when used as function arguments #166

Closed
Demivan opened this issue Jul 24, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@Demivan
Copy link
Contributor

Demivan commented Jul 24, 2023

Vue async component imports are not detected when used as function arguments.

Example of using Quasar Dialog plugin:

function showDialog(componentImport) {
  Dialog.create({
    component: defineAsyncComponent(componentImport),
  })
}

showDialog(() => import('./DialogComponent.vue')) // This import is not detected
showDialog(defineAsyncComponent(() => import('./DialogComponent.vue'))) // This is not detected either

// But this one works
const component = defineAsyncComponent(() => import('./DialogComponent.vue'))
showDialog(component)
// And this works too
const componentImport = () => import('./DialogComponent.vue')
showDialog(componentImport)

Edit: Actually file is marked as used but not the default export.

@Demivan Demivan added the bug Something isn't working label Jul 24, 2023
@webpro webpro closed this as completed in 89296a9 Jul 24, 2023
@webpro
Copy link
Collaborator

webpro commented Jul 24, 2023

🚀 This issue has been resolved in v2.16.2. See Release 2.16.2 for release notes.

@Demivan
Copy link
Contributor Author

Demivan commented Jul 25, 2023

@webpro Thanks for a quick fix and an awesome tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants