Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfix typescript version #114

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Unfix typescript version #114

merged 1 commit into from
Mar 31, 2023

Conversation

zoontek
Copy link
Contributor

@zoontek zoontek commented Mar 31, 2023

Hey 👋

Thanks a lot for this fantastic tool, it's very helpful.
I noticed that you set a fixed version of typescript as dependency, resulting on downloading TS 5.0.2 and 5.0.3.

I don't see why it should be fixed (maybe there's a reason? 😅), so I made this PR.

Thanks!

@webpro
Copy link
Collaborator

webpro commented Mar 31, 2023

No reason, guess I forgot. I did have issues with non-fixed devDependencies, but that's another story.

@webpro webpro merged commit 82f2f79 into webpro-nl:main Mar 31, 2023
@webpro
Copy link
Collaborator

webpro commented Mar 31, 2023

🚀 This pull request is included in v2.4.0. See Release 2.4.0 for release notes.

@webpro
Copy link
Collaborator

webpro commented Mar 31, 2023

Thanks @zoontek

@zoontek zoontek deleted the unfix-ts-version branch March 31, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants