Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal links not working in some cases with vertical slides #453

Closed
nuke-web3 opened this issue Jun 12, 2023 · 4 comments
Closed

Internal links not working in some cases with vertical slides #453

nuke-web3 opened this issue Jun 12, 2023 · 4 comments

Comments

@nuke-web3
Copy link

Here is a minimal reproducible example: https://github.com/NukeManDan/reveal-md/tree/broken-internal-links
(and the delta nuke-web3@75c4954 )

node bin/reveal-md.js demo/ and navigating to http://localhost:1948/sub/deep/d.md#/ will show the behavior:

  • working ones are as expected
  • broken ones will navigate to the title/first slide

Expected behavior is id specified will work with horizontal and vertical slides. Not sure if this is a reveal-md or reveal.js bug (I suspect the former).

@webpro
Copy link
Owner

webpro commented Oct 24, 2023

Can you narrow it down to what links exactly fail and why/when?

@nuke-web3
Copy link
Author

main...NukeManDan:reveal-md:broken-internal-links shows the minimal diff here, where the link I hope are self describing 🤞

when I click a [something](#location) link in the slides, I expect to navigate to the slide in question, in the example here it doesn't navigate to the slide that includes that header.

@webpro
Copy link
Owner

webpro commented Nov 11, 2023

Are you saying that the links like #/1 or #/2/1 are not working?

@webpro
Copy link
Owner

webpro commented Jan 2, 2024

Closing due to inactivity. Not sure I understood, perhaps the answer is "custom internal links are not supported".

@webpro webpro closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants