Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added NACK to section 6.2 #26

Merged
merged 3 commits into from
Apr 15, 2015
Merged

added NACK to section 6.2 #26

merged 3 commits into from
Apr 15, 2015

Conversation

brianraymor
Copy link

No description provided.

@@ -637,7 +637,11 @@ HEADERS [stream 4] +END_STREAM
]]>
</artwork>
</figure>

<t>
The push server MUST generate a 5XX (TBD) if the user agent fails to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this needs to be "MUST push a response with a status code of 5XX" instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@martinthomson
Copy link
Contributor

#17 probably isn't closed by this.

martinthomson added a commit that referenced this pull request Apr 15, 2015
added NACK to section 6.2
@martinthomson martinthomson merged commit 3a19e11 into webpush-wg:master Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants