[FIXED] # UnicodeError while handling a bug #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Z4nzu
changed the title
|
Hii @cclauss, Please Review PR |
cclauss
reviewed
Mar 4, 2023
cclauss
reviewed
Mar 4, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
previously approved these changes
Mar 4, 2023
|
Hi @cclauss, As I am checking lint_python cases are failed due to isinstance(). May I do that changes or how this PR will be merged ? |
|
@iredmail @criptocoko Your reviews, please? |
cclauss
approved these changes
Mar 4, 2023
|
Does this solve the scenario i presented?? because i think the problem is only for the attachments, not the message. The message is already handled here: Line 1483 in 0b67153 I attached the 2 scenarios('non ascii on the attach and the non ascii on the message') where the first one fails and second doesn't. |
|
This is exactly why tests are a great idea. |
|
Please resolve the git conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error occurs when there is an attempt to encode a Unicode character that is not in the ASCII range (i.e., outside the range of 0 to 127) using the ASCII codec. The character in question in your case is '\u2019', which is the right single quotation mark.
Encode the message using a Unicode encoding that supports all characters, such as UTF-8. You can do this by changing the encoding parameter of the encode() method to 'utf-8'
close #757