Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of deduplication policy #332

Merged
merged 1 commit into from Jul 6, 2023

Conversation

wvengen
Copy link
Contributor

@wvengen wvengen commented Jun 15, 2023

The simplest solution for #331 (whole or partial solution, depending how you look at it), allowing configuration of pywb's dedup_policy.

  • Test this actually works.

@wvengen wvengen marked this pull request as ready for review June 15, 2023 13:21
@ikreymer ikreymer requested a review from tw4l July 6, 2023 07:01
@ikreymer
Copy link
Member

ikreymer commented Jul 6, 2023

Thanks for adding this! Don't know if this is the best solution to the verification check issue per se, but not opposed to having this option in general, especially if it helps!

@ikreymer
Copy link
Member

ikreymer commented Jul 6, 2023

One issue however, is that we are planning to move away form pywb for recording (see: https://github.com/webrecorder/browsertrix-crawler/tree/recorder-work) so it may be more difficult to support this exact functionality, though probably should have some sort of dedup options..

util/argParser.js Show resolved Hide resolved
@tw4l tw4l merged commit de2b451 into webrecorder:main Jul 6, 2023
@wvengen
Copy link
Contributor Author

wvengen commented Jul 7, 2023

Thank you for including this change! 🎉

For reference: maybe it's good to point to the issue from here (#331 (comment)) and note that I took a safe set of accepted option values, which work with redis duplicate detection.

Good to know that a new recording path is being taken, thanks for mentioning. Curious to see how that develops!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants