Add Prettier to the repo, and format all the files! #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emma-sg might be easier to redo the prettier past off dev-1.0.0 to avoid the conflicts? |
|
Yeah probably! |
add formatting step to precommit hook
emma-sg
force-pushed
the
recorder-work-ts--typescript-eslint
branch
from
e5b0813
to
22502b1
Compare
|
@ikreymer rebased! Waiting on builds but would appreciate a review |
|
Thanks for the rebase! only thought what if we specified the directories explicitly for |
ikreymer
reviewed
Nov 9, 2023
|
ack, will add updates to ignore files in separate PR. |
ikreymer
added a commit
that referenced
this pull request
Nov 10, 2023
- actually update lint/prettier/git ignore files with scatch, crawls, test-crawls, behaviors, as needed
ikreymer
added a commit
that referenced
this pull request
Nov 10, 2023
- actually update lint/prettier/git ignore files with scatch, crawls, test-crawls, behaviors, as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds prettier to the repo, and sets up the pre-commit hook to auto-format as well as lint.
Should be merged after #425.