Make /app world-readable to better support non-root usage #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, we do set permissions on some of the files already, but I guess doesn't hurt to try. Can try it in the next beta release. |
|
Actually, as is, this is slowing down the build, by 1.5min, as the chmod is expensive. We may need to find out which files need to be world-readable if this is the issue. |
ikreymer
added a commit
that referenced
this pull request
Apr 4, 2024
…)" This reverts commit 23fda68.
ikreymer
added a commit
that referenced
this pull request
Apr 4, 2024
) Reverts #523 The chmod operation is a bit slow, and in testing don't think the CI is related to chmod :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect webrecorder/browsertrix#1625 is failing in CI because browsertrix-crawler sometimes needs to read from
/appafter launching. This causes errors with the non-root deployment.