Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow minio to connect to other regions #543

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

mguella
Copy link
Contributor

@mguella mguella commented Apr 13, 2024

This should address the issue of connecting to buckets stored outside us-east-1 (#515) while the switch from Minio client to AWS SDK is being worked on (#479)

@tw4l
Copy link
Contributor

tw4l commented Apr 15, 2024

Hi @mguella, see my comment here: #515 (comment)

Based on the minio-js developer's response, I think this change may be unnecessary if one uses s3.amazonaws.com as the STORE_ENDPOINT_URL, as minio-js claims to auto-discover the region. But it could use some testing.

@mguella
Copy link
Contributor Author

mguella commented Apr 16, 2024

@tw4l unfortunately that doesn't work with non AWS providers (I've tried both Cloudflare and Tigris) and I think it would be nice to support other S3 compatible storage other than AWS and Minio itself

@ikreymer ikreymer merged commit ea7b2bb into webrecorder:main Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants