improved handling of requests from workers: #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add recorder.hasFrame() frameId to match not just service-worker frameIds but all frameIds, store in frameIdToExecId on the worker data
ikreymer
commented
May 6, 2024
| foundRecorder = recorder; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (!foundRecorder) { | ||
| logger.debug( |
There was a problem hiding this comment.
not sure if this should be a warning.. means something is getting skipped, but maybe debug is ok for that?
There was a problem hiding this comment.
I think the switch to warn here is good, we don't want this getting lost in debug logs
tw4l
approved these changes
May 6, 2024
| foundRecorder = recorder; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (!foundRecorder) { | ||
| logger.debug( |
There was a problem hiding this comment.
I think the switch to warn here is good, we don't want this getting lost in debug logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on sites with regular workers, requests from workers were being skipped as there was no match for the worker frameId
Tests:
Fixes 'Skipping URL from unknown frame' on sites such as https://www.stadttunnel-zug-nein.ch/
Without this fix, many URLs result in this error, and this should eliminate that.