adjust browser viewport to avoid cutting off bottom of page #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- subtract the browser ui height from default viewport computed from screen dimensions - hard-code height to 81px for now - fixes #613, bottom of page being cut-off as viewport height was too big
|
Tested QA from previous versions, no issue with screenshots. |
|
Will merge now for 1.2.0-beta.1 release and can do more testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 81px offset was determined by testing, ideally could get it from somewhere?
Result:
Note: Tested locally, but need to ensure this doesn't break QA when screenshots taken with old viewport, otherwise, need to account for that.