Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Removing Exclusions at Crawl Time Fails #1566

Closed
Shrinks99 opened this issue Mar 1, 2024 · 1 comment · Fixed by #1577
Closed

[Bug]: Removing Exclusions at Crawl Time Fails #1566

Shrinks99 opened this issue Mar 1, 2024 · 1 comment · Fixed by #1577
Assignees
@SuaYoo
Labels
bug Something isn't working
Milestone
v1.9.3

Comments

@Shrinks99
Copy link
Member

Browsertrix Cloud Version

v1.10.0-beta.0-9c38b7d

What did you expect to happen? What happened instead?

When trying to remove an exclusion from a running crawl, the exclusion gets grayed out in the list (scheduled for removal but not out yet) but an error appears telling the user that removing the exclusion failed.

Step-by-step reproduction instructions

  1. Start a new crawl with an exclusion or add an exclusion at crawl time
  2. Try to remove the exclusion
  3. It can't be removed :(

Additional details

image
@Shrinks99 Shrinks99 added the bug Something isn't working label Mar 1, 2024
@Shrinks99 Shrinks99 added this to the v1.9.3 milestone Mar 4, 2024
@SuaYoo
Copy link
Collaborator

SuaYoo commented Mar 6, 2024

Looks like this is related to #1544, text without regex works but seeing seeing "exclusion not found" when removing one with.

@SuaYoo SuaYoo mentioned this issue Mar 6, 2024
Merged
ikreymer pushed a commit that referenced this issue Mar 6, 2024
@SuaYoo
Fix regex escape in exclusion editor text match (#1577)
b6dd376 
- Fixes #1566, #1544

- Fixes issue where "match text" was being displayed as regex when
containing special characters.
ikreymer pushed a commit that referenced this issue Mar 6, 2024
@SuaYoo @ikreymer
Fix regex escape in exclusion editor text match (#1577)
79a217b 
- Fixes #1566, #1544

- Fixes issue where "match text" was being displayed as regex when
containing special characters.
ikreymer pushed a commit that referenced this issue Mar 6, 2024
@SuaYoo @ikreymer
Fix regex escape in exclusion editor text match (#1577)
524bd76 
- Fixes #1566, #1544

- Fixes issue where "match text" was being displayed as regex when
containing special characters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuaYoo SuaYoo

Labels
bug Something isn't working
Projects
Webrecorder Projects
Status: Done!
Milestone
v1.9.3
Development

Successfully merging a pull request may close this issue.

Fix regex escape in exclusion editor text match webrecorder/browsertrix
2 participants
@SuaYoo @Shrinks99