Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Browser profile list not displaying for some users #1764

Closed
SuaYoo opened this issue Apr 30, 2024 · 0 comments · Fixed by #1765
Closed

[Bug]: Browser profile list not displaying for some users #1764

SuaYoo opened this issue Apr 30, 2024 · 0 comments · Fixed by #1765
Assignees
@SuaYoo
Labels
bug Something isn't working front end Requires front end dev work
Milestone
v1.10.0

Comments

@SuaYoo
Copy link
Collaborator

SuaYoo commented Apr 30, 2024 •
edited
Loading

Browsertrix Version

v1.10.0-beta.5-9c7fdb4f

What did you expect to happen? What happened instead?

Browser profiles aren't loading for some users, and instead shows as the org having no browser profiles. Checking the API response shows that the backend is returning them.

Reproduction instructions

See Discord thread

Screenshots / Video

No response

Environment

No response

Additional details

Did some initial investigation--the backend returns null replicas, which is typed as never null, which is throwing an exception.

It's a quick frontend fix to handle null, but we should check if this is expected backend behavior. (cc @tw4l )
@SuaYoo SuaYoo added bug Something isn't working front end Requires front end dev work labels Apr 30, 2024
@SuaYoo SuaYoo self-assigned this Apr 30, 2024
@SuaYoo SuaYoo mentioned this issue Apr 30, 2024
Merged
@SuaYoo SuaYoo added this to the v1.10.0 milestone Apr 30, 2024
ikreymer pushed a commit that referenced this issue Apr 30, 2024
@SuaYoo
Handle null replicas in browser profile (#1765)
37cb297 
Fixes #1764

### Changes

- Handles profile `resource.replicas` being null
- Adds loading indicator when browser profile list is loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuaYoo SuaYoo

Labels
bug Something isn't working front end Requires front end dev work
Projects
Webrecorder Projects
Status: Done!
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

Handle null replicas in browser profile webrecorder/browsertrix
1 participant
@SuaYoo