Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX of QA review embedded replay page navigation #1780

Open
SuaYoo opened this issue May 1, 2024 · 3 comments
Open

Improve UX of QA review embedded replay page navigation #1780

SuaYoo opened this issue May 1, 2024 · 3 comments
Assignees
Labels
back end Requires back end dev work front end Requires front end dev work ui/ux This issue requires UI/UX work

Comments

@SuaYoo
Copy link
Collaborator

SuaYoo commented May 1, 2024

Context

We've currently disabled navigation within the QA review replay frame since there's no way of indicating to users whether the link has been crawled, or allowing them to exit 404 pages. A better user experience would be to allow users to navigate in the replay in sync with the QA review page list.

Requirements

  • Notify <replay-web-page> consumers when navigation occurs
  • Browsertrix API consumers should be able to check whether a page URL is a part of a QA run

Implementation details

  • Fire event from <replay-web-page> when navigation is finished.
  • Navigation event should contain error details like 404 status.
  • Could be either new API endpoint or a url filter on the existing GET /pages endpoint.

Questions

Can we also fire an event when navigation begins? Maybe reuse logic for showing the loading spinner?

@SuaYoo SuaYoo added ui/ux This issue requires UI/UX work front end Requires front end dev work labels May 1, 2024
@SuaYoo
Copy link
Collaborator Author

SuaYoo commented May 1, 2024

Might be achievable with an API GET endpoint that filters pages by page URL

@tw4l
Copy link
Contributor

tw4l commented May 15, 2024

@ikreymer Define what's needed in backend and split into additional issues

@Shrinks99
Copy link
Member

From today's call: Goal is to get this done before QA is considered out of "beta"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back end Requires back end dev work front end Requires front end dev work ui/ux This issue requires UI/UX work
Projects
Status: Implementing
Development

No branches or pull requests

4 participants