Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds favicons! #1584

Merged
merged 16 commits into from Mar 16, 2024
Merged

Adds favicons! #1584

merged 16 commits into from Mar 16, 2024

Conversation

Shrinks99
Copy link
Member

@Shrinks99 Shrinks99 commented Mar 7, 2024

Closes #328

Changes

The app has favicons now!

Added:

  • SVG
    • Changes to slightly brighter colours in dark mode for better contrast!
  • Fallback ICO
  • apple-touch-icon (some browsers also use this, not just iOS)
  • Web manifest with app description
    • Two web manifest icon sizes should users add the app to their local launcher (Windows' Start or macOS' Dock / Launchpad
    • Lighting & render by @emma-sg, thanks!

The manifest and icons are copied to the root directory at build time by webpack. All of the dedicated ways of doing this seemed more complicated than this?

Screenshots

Screenshot 2024-03-15 at 6 39 47 PM Screenshot 2024-03-15 at 6 47 20 PM Screenshot 2024-03-15 at 6 45 39 PM

Caveats / Future

Could adjust the icon colours in dark mode and give it more contrast?

Todo (done!):

  • Create app manifest
  • Update manifest logos with ones that will match our app icons
  • Optimize manifest logos
  • Optimize SVG with SVGO

They don't currently work!
@Shrinks99 Shrinks99 self-assigned this Mar 7, 2024
@Shrinks99 Shrinks99 marked this pull request as ready for review March 8, 2024 18:59
@Shrinks99 Shrinks99 requested a review from emma-sg March 8, 2024 21:12
Copy link
Collaborator

@SuaYoo SuaYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, bubbly! To format the webmanifest file you'll need to add it package.json:

  "lint-staged": {
    "*.{ts,js}": [
      "prettier --write",
      "eslint --fix --quiet"
    ],
-    "*.{html,css,json}": "prettier --write",
+    "*.{html,css,json,webmanifest}": "prettier --write"
  }

@Shrinks99
Copy link
Member Author

Hey, that makes sense! Added.

@Shrinks99 Shrinks99 requested a review from SuaYoo March 12, 2024 01:06
@Shrinks99 Shrinks99 marked this pull request as draft March 15, 2024 03:22
@Shrinks99 Shrinks99 marked this pull request as ready for review March 15, 2024 22:42
@Shrinks99
Copy link
Member Author

Added manifest icons from @emma-sg!

@ikreymer ikreymer merged commit 1093aa9 into main Mar 16, 2024
2 checks passed
@ikreymer ikreymer deleted the frontend-favicons branch March 16, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add favicon
4 participants