Frontend localhost icon fix #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emma-sg
approved these changes
Mar 11, 2024
Shrinks99
requested changes
Mar 11, 2024
Good catch, set shoelace more explicitly to 2.10.x to fix. Will have to look into why dialogs break with the upgrade... |
emma-sg
added a commit
that referenced
this pull request
Apr 15, 2024
Loads `sl-icon` synchronously to get correct base path when running webpack-dev-server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue created, reported here #1534 (comment)
Changes
Loads
sl-iconsynchronously to get correct base path when running webpack-dev-server.Manual testing
Run
yarn --frozen-lockfileto install latest shoelace. Runyarn startand verify icons load.