QA Review UI #1624
Merged
QA Review UI #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
force-pushed
the
frontend-qa-analysis
branch
from
4f2bf38
to
cc27d5b
Compare
Adds initial screenshot comparison tool for testing RWP embeds.
SuaYoo
force-pushed
the
frontend-qa-analysis
branch
from
cc27d5b
to
90e9825
Compare
- Adds a Grouped List helper function: [`frontend/src/components/utils/grouped-list.ts`](https://github.com/webrecorder/browsertrix-cloud/pull/1546/files#diff-7cdd94b36ceca715ce50d68524a31386741561bccdbe1760e1dfae8157f5495e) - Adds a `WeakRef`-based function cache for memoizing function calls, along with tests for it: [`frontend/src/utils/weakCache.ts`](https://github.com/webrecorder/browsertrix-cloud/pull/1546/files#diff-a3164accbef418eedb596ccbb96cf0dee4d4c594fef28a80f02124352875109a) - Adds a page list, along with a bunch of functional helpers: [`frontend/src/features/qa/page-list/page-list.ts`](https://github.com/webrecorder/browsertrix-cloud/pull/1546/files#diff-59fb183decceed95276697a1c274d210b4d4d689e4b5d6eed713b331dfb5b804) - Adds `clsx` for combining classes - Adds a [`TailwindComponent` template for VSCode](https://github.com/webrecorder/browsertrix-cloud/pull/1546/files#diff-64ebc963103ab4a0b8781ad0173ea0de10c4112303531db7c592c6773e25d626) - Reverts changes to the `<btrix-badge>` component - Improves [ItemListControl types](https://github.com/webrecorder/browsertrix-cloud/pull/1546/files#diff-e2e161f4ce6410ed4a5605469aa2260fabdd384e4fcfd4e2978e85d043912579) - Adds an animation helper from Shoelace: [`frontend/src/features/qa/page-list/ui/animate.ts`](https://github.com/webrecorder/browsertrix-cloud/pull/1546/files#diff-5e74f8833205ed5700da8ba2ea81d8aff110a93add8bd19c35ff5cd579f71a4d) - Adds and enables `@tailwindcss/container-queries` for future use - Updates `prettier-plugin-tailwindcss` and ensures that the VSCode Prettier extension uses the correct prettier config & plugins
Adds initial screenshot comparison tool for testing RWP embeds.
SuaYoo
force-pushed
the
frontend-qa-analysis
branch
from
8b7f9f1
to
b6d506e
Compare
Optimize loading: create a proxy iframe for loading from service worker, to be able to fetch() directly from serviceworker: - fetch to blob and use blob URL for `<img>` - fetch to text for text tab - fetch json for resources Text Tab: Show text content in each pane, use diff library for text diff Resources: Aggregate resources JSON by 'type', also group into good (status < 400) /bad (status >= 400) Minor styling tweaks: split nav bar into two rows, add height to replay. Only load url in RWP when actually showing replay to avoid unnecessary background loading. Update data when QA Item is toggled --------- Co-authored-by: sua yoo <sua@suayoo.com>
This was referenced Apr 3, 2024
|
Will take a deeper look tomorrow, initial thought: This is starting to really come together!!
EDIT: Lets save button colours for later, don't wanna get hung up on them here! |
… crawl item endpoint is registered in RWP SW, even if there is no data. if not registered, triggers injecting RWP and awaiting message
### Changes - Changes second level status icon to slash-square (app wide) - Updates finish review button - Changes to success state, hopefully better exemplifies that this is the final action compared to "primary" which is used for things we want to highlight? - Adds icon - Adds microscope icon for review button
disable devServer compression for firefox
|
Added some additional fixes, and I think this may be ready to merge! |
ikreymer
reviewed
Apr 3, 2024
ikreymer
reviewed
Apr 3, 2024
…h fallthroughs, remove unneeded Server-Worker-Allowed header, in both nginx and devServer
Shrinks99
reviewed
Apr 4, 2024
emma-sg
reviewed
Apr 4, 2024
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
Shrinks99
approved these changes
Apr 4, 2024
emma-sg
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1477
Changes