Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Fixes the "Replay Latest Crawl" button path #1636

Merged
merged 1 commit into from Apr 3, 2024

Conversation

Shrinks99
Copy link
Member

No issue for this one, but another minor gripe that has bugged me for a while :)

Changes

  • Fixes the path for the "Replay Latest Crawl" button on the watch crawl page when the crawl workflow isn't running
    • Removes the extra ?workflowid in the URL after the #replay that causes the app to not direct the user to the correct tab
    • This also means the back button won't direct users back to the previous crawl workflow and instead to the all crawls list... I think this is reasonable and probably better than directing them to the wrong page, but should also be improved with breadcrumb navigation in the future.

@Shrinks99 Shrinks99 requested review from SuaYoo, ikreymer and emma-sg and removed request for SuaYoo and ikreymer March 28, 2024 03:54
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Tested & seems to work

@Shrinks99 Shrinks99 merged commit 432a727 into main Apr 3, 2024
2 checks passed
@Shrinks99 Shrinks99 deleted the frontend-replaybuttonfix branch April 3, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

None yet

2 participants