Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit eslint errors during webpack builds & during dev #1667

Merged
merged 3 commits into from Apr 9, 2024

Conversation

emma-sg
Copy link
Member

@emma-sg emma-sg commented Apr 9, 2024

Following discussion on Discord, this enables ESLint errors showing up during dev within Webpack, and also enforces that all issues (both warnings and errors) will cause builds to fail during CI.

Other changes:

  • Updates some dependencies (primarily to versions that are type-checked)

@emma-sg emma-sg added the tooling Tooling and developer experience work label Apr 9, 2024
@emma-sg emma-sg requested a review from SuaYoo April 9, 2024 20:35
@emma-sg emma-sg self-assigned this Apr 9, 2024
@emma-sg emma-sg requested a review from ikreymer April 9, 2024 20:35
@emma-sg emma-sg merged commit 9aba24a into main Apr 9, 2024
2 checks passed
@emma-sg emma-sg deleted the report-eslint-issues-in-webpack branch April 9, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Tooling and developer experience work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant