Remove pages from QA Configmap #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e (256K) was originally an optimization/work around to reading pages from WACZ pages.jsonl however, the size limit makes this a bit less useful. ideally, the pages can be read from WACZ(s) w/o having to store all the pages in the configmap
…ng the crawl as planned
|
Wonder if there's a way to make people aware that latest crawler will get best results (i.e. that some pages may be missing from pages files in older versions of crawler)? Maybe since this is still very much in dev it's a non-issue? |
Yep, we will switch to 1.1.0 crawler when we launch QA, and it will be intended crawls going forward, other 1.0.x crawls will be best effort, and 0.x crawls will be manual review only. |
tw4l
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1670
No longer need to pass pages to the ConfigMap. The ConfigMap has a size limit and will fail if there are too many pages.
Note: a previous workaround would keep this, but would check the size of the ConfigMap and add pages if size was <200K. Could still do that, but this seems like a cleaner fix going forward.
With this change, the page list for QA will be read directly from the WACZ files pages.jsonl / extraPages.jsonl entries.