Improve reliability of backend tests #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use pytest fixtures rather than globals - Give tests time for async updates to happen in while loop
Use a while loop for up to 60 seconds to fix an intermittent test failure.
|
Updated to include test reliability improvements for intermittently failing test_uploads and test_qa modules as well - namely, adding certain checks into timed while loops and replacing globals with pytest fixtures. |
|
Sorry for the delay after creeping the scope up a bit, but I think this should be good now! |
tw4l
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging tests for #1625, I stumbled upon over the use of globals instead of fixtures in
test_profiles.py. I also added some limits to thewhile True- loops to avoid blocking a CI worker for several hours.