Add reviewStatus, qaState, and qaRunCount sort options to crawls/all-crawls list endpoints #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reviewStatus, qaRunCount, and activeQAState as sort options for crawls. Adds qaRunCount and activeQAState to CrawlOut as well.
Rename activeQAState sort option to just qaState, which sorts by activeQAState first, then lastQAState. Both fields are returned with the data now. This requires a fair bit of computation in the Mongo aggregation so we may want to consider moving to precomputing like with workflow last crawl information at some point. That would also allow the sort to be more visible based on a single field.
2 tasks
ikreymer
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend work for #1672
Adds new sort options to /crawls and /all-crawls GET list endpoints:
reviewStatusqaRunCount: number of completed QA runs for crawl (also added to CrawlOut)qaState(sorts byactiveQAStatefirst, thenlastQAState, both of which are added to CrawlOut)