Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Frontend QA Polish Changes #1709

Merged
merged 12 commits into from Apr 23, 2024
Merged

More Frontend QA Polish Changes #1709

merged 12 commits into from Apr 23, 2024

Conversation

emma-sg
Copy link
Member

@emma-sg emma-sg commented Apr 20, 2024

Sort of relevant to #1696

  • Improves a number of layout elements at smaller viewport sizes (specifically, letting button groups wrap onto next lines & ensure titles can't shrink to 0 width)
  • Adds "No page title" to places where there'd normally be a page title but isn't
  • Applies grid styling to page list area to fix overflow issues
    • When selecting or loading with a page selected that's farther down on the page list, the top of the page header could be scrolled away from, and there'd be no way to scroll back because the area had overflow: hidden applied
  • Adds default width and height to image comparer element, so that it displays correctly when images haven't loaded and doesn't change layout when images load

@emma-sg emma-sg added the front end Requires front end dev work label Apr 20, 2024
@emma-sg emma-sg requested a review from Shrinks99 April 20, 2024 07:57
- Make gap between buttons smaller (8px)
@Shrinks99
Copy link
Member

Shrinks99 commented Apr 21, 2024

On the train RN but ran into some layout issues with the new grid area layouts. Can expand later but wanted to flag.

Screenshot 2024-04-20 at 4 10 26 PM

@emma-sg emma-sg mentioned this pull request Apr 22, 2024
23 tasks
@emma-sg
Copy link
Member Author

emma-sg commented Apr 22, 2024

@Shrinks99 this should be fixed with 11f8f46!

@emma-sg emma-sg requested a review from SuaYoo April 22, 2024 19:25
@Shrinks99
Copy link
Member

Table row cells are a bit large now haha

Screenshot 2024-04-23 at 1 21 48 AM

Everything else looks good!!

@emma-sg
Copy link
Member Author

emma-sg commented Apr 22, 2024

Oh I fixed that but I did so here instead of this PR whoops! just a sec

@Shrinks99
Copy link
Member

Ah no worries then, reviewing out of order! :)

@emma-sg emma-sg merged commit 7710be0 into main Apr 23, 2024
2 checks passed
@emma-sg emma-sg deleted the frontend-qa-responsive-fixes branch April 23, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front end Requires front end dev work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants