Support sorting by last QA started time #1712
Conversation
Include active QA in these (will already become first since we're sorted by started) instead of separating it out into a separate field. This is more consistent with how we handle workflows. We do however keep activeQAStats, as that can be used to quickly determine if there is an active QA run and show a progress bar for it if so.
|
@ikreymer I took a crack at simplifying the QA sorting fields and making them more consistent with what we do for workflows. Namely:
Ready for your eyes. This will require some small tweaks to #1683 , will push those next. And if we want to revert the changes, can always just drop the commit. |
- Rename QA sort fields to `lastQAState` and `lastQAStarted` - Include active/current QA in last, to be consistent with workflows - Check if current QA based on `activeQAStats`, since we now removed `activeQAState` as redundant
|
#1683 updated to match! |
- Rename QA sort fields to `lastQAState` and `lastQAStarted` - Include active/current QA in last, to be consistent with workflows - Check if current QA based on `activeQAStats`, since we now removed `activeQAState` as redundant
|
Thanks for the update! Only question is if new operators like concatArrays would effect perf, but since this is all on one object, hopefully fairly negligible. |
FWIW they definitely do to some degree but we can see if that becomes a problem. Likely the most performant solution longterm is to precompute more of these values, but that comes with its own complexity tradeoff so I'd wait to see if it becomes an issue. |
To support #1683, it would be useful to be able to sort by 'last QA start time' in addition to/instead of last QA state.