Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misleading upload error notification #1768

Merged
merged 1 commit into from Apr 30, 2024
Merged

Fix misleading upload error notification #1768

merged 1 commit into from Apr 30, 2024

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented Apr 30, 2024

Fixes #1767

Manual testing

  1. Log in as any role
  2. Go to "Archived Items"
  3. Click an upload. Verify toast errors aren't shown. (see issue screenshots)

@SuaYoo SuaYoo requested review from ikreymer and emma-sg April 30, 2024 17:12
@ikreymer ikreymer merged commit fe65ccf into main Apr 30, 2024
2 checks passed
@ikreymer ikreymer deleted the frontend-fix-upload-settings-error-notification branch April 30, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer Awaiting requested review from ikreymer

@emma-sg emma-sg Awaiting requested review from emma-sg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Uploads incorrrectly show that settings can't be retrieved
2 participants
@SuaYoo @ikreymer