Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA review tooltip + comment improvements #1779

Merged
merged 7 commits into from
May 1, 2024

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented May 1, 2024

Resolves #1761

Changes

  • Switches QA review page chip tooltip colors to dark text on light background
  • Shows newest comment when hovering over comment cell in QA tab page list to match tooltip in QA review page list
  • Validates textarea max entry for description and comments

Manual testing

  1. Log in as crawler
  2. Select to reviewed archived item with page comments
  3. Go to QA tab
  4. Hover over comment icon in "Pages" table. Verify tooltip with latest comment is shown
  5. Click page to go into review
  6. Hover over page heuristic preview chip. Verify tooltip renders dark-on-light
  7. Click page comment button to open comment dialog
  8. Enter text. Verify max length text help updates as expected
  9. Try to save with over max length. Verify you're prevented from saving
  10. Limit text to max length. Verify you're able to save
  11. Repeat 8-10 for review description

Screenshots

Page Image/video
Archived Item Detail - QA - Pages Short comment:
Screenshot 2024-05-01 at 9 58 17 AM
Long comment:
Screenshot 2024-05-01 at 9 58 24 AM
Archived Item - QA Review - Page comment dialog Screenshot 2024-05-01 at 9 56 53 AM
Archived Item - QA Review - Item review dialog Screenshot 2024-05-01 at 9 57 48 AM
Archived Item - QA Review - Page heuristic chip tooltip Screenshot 2024-05-01 at 10 09 01 AM

@Shrinks99

This comment was marked as resolved.

@emma-sg
Copy link
Member

emma-sg commented May 1, 2024

From Discord: we've hidden arrows here because properly doing arrows with borders would likely require forking shoelace's tooltip element — we'll maybe come back to this later?

@ikreymer ikreymer merged commit e7dbf91 into main May 1, 2024
2 checks passed
@ikreymer ikreymer deleted the frontend-qa-review-tooltip-improvements branch May 1, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA review tooltip/popover improvements
4 participants