Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend open registration flow #30

Merged
merged 9 commits into from Nov 30, 2021
Merged

Add frontend open registration flow #30

merged 9 commits into from Nov 30, 2021

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented Nov 24, 2021

(#28) Initial pass at sign up flow for when open registration is enabled.

@ikreymer I'll leave this open for testing backend changes to send emails. Right now the verify path is configured as /verify?token= but this can easily change.

Flow:

  1. User signs up with email and password
  2. Sign up success:
    a. If user is not active, shown success message
    b. If user is immediately active upon sign up (checking is_active), user is logged in automatically and redirected to dashboard
    1. user is given option to resend verification email from account settings page
  3. User clicks verification email, redirected to /verify
    a. If verification is successful, user is sent to log in page (or is there a way to automatically log them in?)

Manual testing

  1. Run app with yarn start-dev
  2. Go to /sign-up and sign up. Verify that you're redirected to "my account" on success (TODO UX improvements, maybe show sign up toast, or redirect to a welcome page?)
  3. Go to /account/settings. Verify that email shows as "unverified"
  4. Click "resend verification email". Verify that status changes to "sent"
  5. Go to /verify?token=something. Verify that you see a "This verification email is not valid." error message

Screenshots

Sign up form:
Screen Shot 2021-11-24 at 3 34 49 PM

Verification status:
Screen Shot 2021-11-24 at 3 36 44 PM

@SuaYoo SuaYoo requested a review from ikreymer November 24, 2021 23:40
@SuaYoo SuaYoo self-assigned this Nov 24, 2021
Base automatically changed from frontend-path-query to main November 27, 2021 03:45
@SuaYoo SuaYoo merged commit 3fa85c8 into main Nov 30, 2021
@SuaYoo SuaYoo deleted the frontend-sign-up branch November 30, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant