Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crawl config detail views #97

Merged
merged 17 commits into from Jan 25, 2022
Merged

Crawl config detail views #97

merged 17 commits into from Jan 25, 2022

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented Jan 23, 2022

WIP #89

  • Adjust details in list view for improved readability
  • New detail view page with configuration, schedule and crawl details

TODOs recorded here #100

Manual testing

  1. Run app and go to crawl template list page. Click on a crawl template name, verify it takes you to the detail page
  2. Choose or create a template with more than 3 seed URLs. Verify the detail view has a "show more" button that displays all the URLs
  3. Click "Advanced Configuration". It should show the entire JSON config object
  4. Scroll to "Crawls" section and click "Run now". Verify crawl starts

Screenshots

*Enhancements to last/next crawl detail in list view
Screen Shot 2022-01-24 at 6 52 43 PM

New detail view
Screen Shot 2022-01-24 at 6 53 08 PM

Expanded seeds
Screen Shot 2022-01-24 at 6 53 44 PM

Expanded "Advanced Configuration"
Screen Shot 2022-01-24 at 6 54 04 PM

Formatted schedule
Screen Shot 2022-01-24 at 6 54 49 PM

Banner in detail view when crawl is running
Screen Shot 2022-01-24 at 6 54 21 PM

Crawls section when no crawl is currently running
Screen Shot 2022-01-24 at 7 07 54 PM

@SuaYoo SuaYoo mentioned this pull request Jan 23, 2022
9 tasks
@SuaYoo SuaYoo requested a review from ikreymer January 25, 2022 02:34
@SuaYoo SuaYoo marked this pull request as ready for review January 25, 2022 03:13
@ikreymer
Copy link
Member

Looks great! Only suggestion is perhaps to add a 'Details' entry to the falafel menu, just in case user doesn't figure out clicking on the title (as i didn't initially, heh).
Can make a separate issue for the remaining todos.

@SuaYoo SuaYoo merged commit 3a461d8 into main Jan 25, 2022
@SuaYoo SuaYoo deleted the crawl-config-list-details branch January 25, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants