Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL of the zoom image in VueUI not using static_prefix #876

Closed
Quirinus opened this issue Nov 22, 2023 · 2 comments · Fixed by #895
Closed

URL of the zoom image in VueUI not using static_prefix #876

Quirinus opened this issue Nov 22, 2023 · 2 comments · Fixed by #895
Assignees

Comments

@Quirinus
Copy link
Contributor

Quirinus commented Nov 22, 2023

Describe the bug

As the title says: the URL of the zoom image in VueUI is not using static_prefix.

So, if static_prefix in config.yaml is set to something that's not "static" (default), that makes the image source point to the wrong URL (always hardcoded to /static/zoom-out-icon-333316.png), making the image not load/appear broken.

Steps to reproduce the bug

Change the static_prefix in the config.yaml, use the VueUI timeline, zoom somewhere, the zoom image is missing/broken.

Expected behavior

The zoom image should not be missing.

Screenshots

image

Currently the /static/ part is hardcoded, instead of read from static_prefix in config.yaml.

Environment

  • Version: pywb 2.7.4

Additional context

Should be a simple fix in, adding the static prefix to the URL instead of hardcoding it: https://github.com/webrecorder/pywb/blob/main/pywb/static/vue/vueui.js

Search for /static/zoom-out-icon-333316.png, change the /static/ part to point to the static_prefix set in config.yaml.
Regenerate the source map.

I might give it a try when I get some time.

@tw4l
Copy link
Contributor

tw4l commented Apr 4, 2024

Thanks @Quirinus ! I opted to just replace this icon with a fontawesome icon, since that's how we're handling over icons like this in the header. One fewer static file to worry about :)

@tw4l tw4l closed this as completed in #895 Apr 17, 2024
@Quirinus
Copy link
Contributor Author

Thanks @Quirinus ! I opted to just replace this icon with a fontawesome icon, since that's how we're handling over icons like this in the header. One fewer static file to worry about :)

Great, even better, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

2 participants