Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make package exports explicit #337

Closed
emma-sg opened this issue Jun 18, 2024 · 0 comments · Fixed by #336
Closed

[Feature]: Make package exports explicit #337

emma-sg opened this issue Jun 18, 2024 · 0 comments · Fixed by #336
Assignees
Labels
enhancement New feature or request javascript Pull requests that update Javascript code

Comments

@emma-sg
Copy link
Member

emma-sg commented Jun 18, 2024

Context

Currently, almost all files are included in the package exports. This leads to some frustrating user experiences when trying to consume various parts of the package in another package, as in order for types to be available, you have to import the un-bundled src files, which means your bundler needs to know how to handle all the file types in the same way that the bundler in this repo does, but inside node_modules.

What change would you like to see?

Files meant to be consumed from other packages should be easily accessible as bundled javascript with type declarations alongside, and files not meant for consumption shouldn't be importable.

Requirements

No response

Todo

No response

@emma-sg emma-sg added enhancement New feature or request javascript Pull requests that update Javascript code labels Jun 18, 2024
@emma-sg emma-sg self-assigned this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

1 participant