Surt detection fix for MultiWACZ #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reverse logic: use 'nonSurt' to indicate that not using surt mode - previously, wacz files defaulted to non-surt, but should be opposite, given most wacz files use surt ordering! - save 'nonSurt' as property of wacz file, default to false - waczfiles w/o 'nonSurt' are assumed to have surt-ordered index fixes issue in webrecorder/replayweb.page#174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MultiWACZ implementation in 2.16.0 resulted in a regression with SURT detection.
To make this work more smoothly, reversing the logic, as most WACZ files use SURT-based indexes, use that by default.
Add a 'nonSurt' flag to WACZFile, that, if set, will be using non-surt mode for that WACZ.
fixes issue in webrecorder/replayweb.page#174