-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
be open-minded about byte and dict headers #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand the coveralls fail. The marked line is executed by both python2 and python3. |
shit. missing a file. |
Oy. Hit the "squash merge" button :-) |
Thanks for this, and sorry for the delay. I wonder if its worth optimizing for headers already being in str format:
I suppose its unlikely that there'd be a mix of str and byte headers, but not sure if this would really make any difference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as discussed in #16
I kind of punted on converting bytes/str/whatever for Python 2 because I don't really understand it. It still does dict -> list for python2.
If the user happens to have multidict installed (part of aiohttp), then the multidict tests will run. This is optional because warcio strives to avoid external dependencies. If there's a more-correct way to get that into the CI, I'd love to know it.