Fix example digests, additional checks, compute_headers_buffer() cleanup #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tests: fix incorrect digests for example.warc, example.warc.gz - ensure each example file is checked to ensure no invalid digests (and no checks for arc files) - move all digest checking to test_check_digest_examples.py headers buffer cleanup: move headers buffer computation directly into StatusAndHeaders via compute_headers_buffer() instead of in warcwriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a fix for the incorrect digests in example.warc and example.warc.gz, but also ended up adding additional per-file tests to ensure all example digests (except for those marked as skip) are valid.
Started before the digest checking tool from @wumpus was ready, but then refactored to use the new cli, and moved all the digest checking tests to new test file.
Also includes a leftover cleanup: the headers buffer computation is now directly in StatusAndHeaders via compute_headers_buffer() instead of in WarcWriter