fix ensure_digest(block=True) call if no headers_buffer is available: #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make ensure_digest() a regular method and move header_filter into RecordBuilder to support optional filter of headers during record creation add test for calling ensure_digest() on existing record bump version to 1.7.1
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 98.37% 98.49% +0.12%
==========================================
Files 18 18
Lines 1599 1598 -1
Branches 256 256
==========================================
+ Hits 1573 1574 +1
+ Misses 5 4 -1
+ Partials 21 20 -1
Continue to review full report at Codecov.
|
N0taN3rd
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
ensure_digest(block=True)on a record with no headers_buffer computed would cause an exception as RecordBuilder would access aselfin a class method.warcio/warcio/recordbuilder.py
Line 187 in 3fffe1e
Fixing so
header_filteris now a member of RecordBuilder, andensure_digestremains a regular method.Added test for
ensure_digest(block=True, payload=True)Currently, Webrecorder is calling
ensure_digest(block=True, payload=True)explicitly which might not be correct/necessary (https://github.com/webrecorder/webrecorder/blob/master/webrecorder/webrecorder/rec/webrecrecorder.py#L370) -- I think it does this for side-effect of computing the payload length for chunked payload and should be examined itself. Nevertheless, that should not cause warcio to break.